corp186 <[email protected]> added the comment: The pes fragmentation part of the patch is necessary if subtitle packets are greater than 65535 because only video streams may have unbounded packet lengths according to ISO/IEC 13818-1. This is the definition of the PES packet lengths from the standard:
PES_packet_length – A 16-bit field specifying the number of bytes in the PES packet following the last byte of the field. A value of 0 indicates that the PES packet length is neither specified nor bounded and is allowed only in PES packets whose payload consists of bytes from a video elementary stream contained in Transport Stream packets. Personally, I don't care if you accept this part or not. I had already written it before you mentioned unbounded packet sizes, so I decided to leave it in. It at least makes sure that any future changes to the mpegtsenc code won't create bounded packets greater than 65535 bytes in length. The standard also specifies stream types other than just audio, video, subtitle, and system information. There may be a point in the future where this code is necessary. Please let me know what parts you want chunked into individual patches. I will split out the PTS/DTS changes into a separate patch. _____________________________________________________ FFmpeg issue tracker <[email protected]> <https://roundup.ffmpeg.org/roundup/ffmpeg/issue1053> _____________________________________________________
