Baptiste Coudurier <[email protected]> added the comment:

On 10/12/2009 3:06 PM, Justin Ruggles wrote:
>
> Justin Ruggles<[email protected]>  added the comment:
>
> Baptiste Coudurier wrote:
>
>> Baptiste Coudurier<[email protected]>  added the comment:
>>
>> On 10/11/09 1:02 PM, Justin Ruggles wrote:
>>> Justin Ruggles<[email protected]>   added the comment:
>>>
>>> trying to replace the file with new file...
>>>
>>> ----------
>>> nosy:  -jbr
>>>
>>> _____________________________________________________
>>> FFmpeg issue tracker<[email protected]>
>>> <https://roundup.ffmpeg.org/roundup/ffmpeg/issue1455>
>>> _____________________________________________________
>>>
>>>
>>> aiff_data_size_2.patch
>>>
>>>
>>> diff --git a/libavformat/aiff.c b/libavformat/aiff.c
>>> index 570e05d..9501a7b 100644
>>> --- a/libavformat/aiff.c
>>> +++ b/libavformat/aiff.c
>>> @@ -46,6 +46,10 @@ static const AVCodecTag codec_aiff_tags[] = {
>>>    #define AIFF                    0
>>>    #define AIFF_C_VERSION1         0xA2805140
>>>
>>> +typedef struct {
>>> +    int64_t data_end;
>>> +} AIFFInputContext;
>>> +
>>
>> AIFFContext
>
> There is already an AIFFOutputContext in the same file.  I chose to name
> the new struct AIFFInputContext to distinguish between the two.  I guess
> I could also merge them, even though the fields used are mutually
> exclusive between the muxer and demuxer.

Right, name is fine then.

> Well, really it would be good to split the file, but that's a different
> issue...

Definitely welcome :)

_____________________________________________________
FFmpeg issue tracker <[email protected]>
<https://roundup.ffmpeg.org/roundup/ffmpeg/issue1455>
_____________________________________________________

Reply via email to