New submission from Nicolas Kaiser <[email protected]>:

Hi there!

I noticed a return value that gets overwritten. Just wanted to
bring it to your attention, as I'm not sure this is intended at
this point, and might indicate a problem.

Best regards,
Nicolas Kaiser

--- ./libavcodec/h263dec.c      2010-11-05 20:27:07.891685900 +0100
@@ -401,13 +401,10 @@ retry:
     } else if (CONFIG_MSMPEG4_DECODER && s->msmpeg4_version) {
         ret = msmpeg4_decode_picture_header(s);
     } else if (CONFIG_MPEG4_DECODER && s->h263_pred) {
         if(s->avctx->extradata_size && s->picture_number==0){
             GetBitContext gb;
 
             init_get_bits(&gb, s->avctx->extradata, 
s->avctx->extradata_size*8);
->           ret = ff_mpeg4_decode_picture_header(s, &gb);
         }
->       ret = ff_mpeg4_decode_picture_header(s, &s->gb);
     } else if (CONFIG_H263I_DECODER && s->codec_id == CODEC_ID_H263I) {
         ret = ff_intel_h263_decode_picture_header(s);
     } else if (CONFIG_FLV_DECODER && s->h263_flv) {

----------
messages: 12467
priority: normal
status: new
substatus: new
title: libavcodec/h263dec.c: overwritten return value
type: bug

________________________________________________
FFmpeg issue tracker <[email protected]>
<https://roundup.ffmpeg.org/issue2343>
________________________________________________

Reply via email to