Reimar Döffinger <b...@reimardoeffinger.de> added the comment:
On Mon, Dec 06, 2010 at 08:11:37PM +0000, Baptiste Coudurier wrote:
> On 12/6/10 11:42 AM, Reimar Döffinger wrote:
> > On Mon, Dec 06, 2010 at 11:27:26AM +0000, Baptiste Coudurier wrote:
> >> + // Handles VFR by flushing page because this frame needs to have a
> >> timestamp
> >> + if (st->codec->codec_id == CODEC_ID_THEORA &&
> >> + ogg_granule_to_timestamp(oggstream, granule) >
> >> + ogg_granule_to_timestamp(oggstream, oggstream->last_granule) + 1)
> >> {
> >
> > Checking the codec_id feels wrong and contradicts the comment...
>
> THEORA is the only video codec we support in the ogg muxer currently.
Why not check codec_type (for CODEC_TYPE_VIDEO) if that's what's intended?
> > Also should the < case be handled in some special case (no idea it can
> > even happen).
>
> I don't think this can happen, av_write_frame would fail before.
I think so too, my suggestion was just to think if it makes sense to do
something in case e.g. we change av_write_frame not to fail for it.
Either way those were just nits.
________________________________________________
FFmpeg issue tracker <iss...@roundup.ffmpeg.org>
<https://roundup.ffmpeg.org/issue2398>
________________________________________________
