On Mon, Jul 27, 2009 at 04:38:56AM -0300, Ramiro Polla wrote: > On Mon, Jul 27, 2009 at 3:52 AM, Michael Niedermayer<[email protected]> wrote: > > On Mon, Jul 27, 2009 at 03:27:58AM -0300, Ramiro Polla wrote: > >> On Fri, Jul 24, 2009 at 10:05 AM, Michael Niedermayer<[email protected]> > >> wrote: > >> > On Thu, Jul 23, 2009 at 10:56:34PM -0300, Ramiro Polla wrote: > >> >> Attached are some patches for the fast bilinear scaler, while I wait > >> >> on Michael's answer on the previous message regarding fast_bilinear. > >> >> > >> >> Hmm, should these patches go to -devel or -soc? > >> >> > >> >> Ramiro Polla > >> > > >> >> swscale.c | 61 > >> >> +++++++++++++++++++++++++++++-------------------------------- > >> >> 1 file changed, 29 insertions(+), 32 deletions(-) > >> >> d369af493c0c7e0f5d040ed71c1b232cf30a31bc > >> >> 0001-Avoid-duplication-in-initMMX2HScaler.patch > >> >> From 05c4bf02481265155b7d25438e9b32ceefcd578e Mon Sep 17 00:00:00 2001 > >> >> From: Ramiro Polla <ram...@macbuntu.(none)> > >> >> Date: Thu, 23 Jul 2009 21:56:57 -0300 > >> >> Subject: [PATCH] Avoid duplication in initMMX2HScaler() > >> > > >> > might be ok but it isnt particularely readable so iam not sure ... > >> > >> What's not readable? The resulting code or the patch? There's > > > > the patch > > > > > >> currently 1 patch for factorization, then a cleanup which indents and > >> changes some {}s, and the last patch (which you didn't comment) is > >> unrelated. Should I try adding intermediate steps to make the > >> factorization more clear? > > > > if you can easily make it more readable please do > > Attached patches should make it much more readable, and have no > unrelated cosmetics. The resulting code looks nicer too IMHO.
> swscale.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > fa67f08d579b11d577b0caab234eb0592b39de09 > 0001-MMX2-scaler-add-variable-to-ease-factorization-of-i.patch > From dfa3eb729b2d2c4ed392d044854a8d28fa9ee542 Mon Sep 17 00:00:00 2001 > From: Ramiro Polla <[email protected]> > Date: Mon, 27 Jul 2009 04:23:03 -0300 > Subject: [PATCH] MMX2 scaler: add variable to ease factorization of > initMMX2Scaler(). ok [...] > swscale.c | 40 ++++++++++------------------------------ > 1 file changed, 10 insertions(+), 30 deletions(-) > f751236952bb19386541a312b1b89987cbaaceb4 > 0002-MMX2-scaler-factorize-initMMX2Scaler.patch > From e1d6299981e09414e3820a57e57fafc0f48bb93c Mon Sep 17 00:00:00 2001 > From: Ramiro Polla <[email protected]> > Date: Mon, 27 Jul 2009 04:24:42 -0300 > Subject: [PATCH] MMX2 scaler: factorize initMMX2Scaler(). ok [...] > swscale.c | 35 ++++++++++++++++------------------- > 1 file changed, 16 insertions(+), 19 deletions(-) > ab112bb65e3b096a609e6ab97a28b36aa4bccdd2 0003-Cosmetics.patch > From a68dee5e39cf3175aa814192b6ed5719135f04ea Mon Sep 17 00:00:00 2001 > From: Ramiro Polla <[email protected]> > Date: Mon, 27 Jul 2009 04:26:50 -0300 > Subject: [PATCH] Cosmetics. ok but its debateable i how far that is all cosmetics [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Everything should be made as simple as possible, but not simpler. -- Albert Einstein
signature.asc
Description: Digital signature
_______________________________________________ FFmpeg-soc mailing list [email protected] https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-soc
