Hi Sascha, On Mon, Aug 31, 2009 at 2:28 PM, Sascha Sommer<[email protected]> wrote: > On Montag, 31. August 2009, Ronald S. Bultje wrote: >> On Mon, Aug 31, 2009 at 2:07 PM, faust3<[email protected]> wrote: >> > + *...@return decoded subframe length on success, < 0 in case of an error >> >> [..] >> >> > - if (!(subframe_len = decode_subframe_length(s, >> > min_channel_len))) + if ((subframe_len = decode_subframe_length(s, >> > min_channel_len)) <= 0) >> >> <= should be <. > > subframe_len == 0 might be no error for decode_subframe_length > But it is an error for the calling function in this case. > (Although this should not happen with the current implementation)
Of course - could you clarify that with a comment to prevent more dummy questions like mine? :-). Great work btw! Ronald _______________________________________________ FFmpeg-soc mailing list [email protected] https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-soc
