On Wed, 2009-12-02 at 17:14 -0500, Alex Converse wrote: > On Wed, Dec 2, 2009 at 3:04 AM, Robert Swain <robert.sw...@gmail.com> wrote: > > On Tue, 2009-12-01 at 16:10 -0500, Alex Converse wrote: > >> Should this be split more? > > > > If you could split out anything that's not adding all of ff_apply_sbr() > > then that would be appreciated. It looks like there are quite a few > > function argument fixes and variable/array alterations and such in there > > as well. > > > > Split
Thanks. :) > > But, if it would take too long and you don't have too much time spare to > > work on this, as far as I'm concerned it's more important to have it > > working than to have completely clean history when it doesn't work yet. > > > >> I left out the half of this patch that wires this into aac.c since > >> that is still ugly. > > > > OK, you can submit/commit those separately. > > > >> This also doesn't yet handle downsampled SBR and is only tested with > >> SBR in pure upsampling mode. Still it decodes al_sbr_qmf_* perfectly. > > > > What are these low-frequency functions that you've added in this patch? > > Did I miss those when coding the rest of it? > > > > Those were missing. OK. Regards, Rob _______________________________________________ FFmpeg-soc mailing list FFmpeg-soc@mplayerhq.hu https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-soc