On Fri, 4 Jun 2010, Josh Allmann wrote:
> On 3 June 2010 07:34, Luca Barbato <[email protected]> wrote:
> >
> > + if (!av_base64_encode(base64buf, sizeof(base64buf), buf,
> > strlen(buf))) {
> > + av_log(s, AV_LOG_ERROR, "Unable to base64 encode RTSP.\n");
> > + return;
> > + }
> >
> > currently this function assumes that it cannot fail, probably we should
> > propagate errors.
> >
>
> Done, added a fifth patch for this. I only check and propagate errors
> within ff_rtsp_send_cmd* functions, but I don't do anything about them
> when called from other ff_rtsp* functions.
Propagating errors generally is a very good idea. For this particular
case, the only thing that could fail with base64 is that the output buffer
isn't large enough, and we already make sure it's large enough. But I'm ok
with it either way.
// Martin
_______________________________________________
FFmpeg-soc mailing list
[email protected]
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-soc
