On Wed, Jun 02, 2010 at 11:18:19AM +0300, Martin Storsjö wrote: > On Wed, 2 Jun 2010, Josh Allmann wrote: > > > On 2 June 2010 00:01, Martin Storsjö <[email protected]> wrote: > > > On Tue, 1 Jun 2010, Josh Allmann wrote: [...] > > > Also, as for replacing/adding headers.. I'm not sure that you'd want to > > > skip all of the default headers if you're adding custom ones, e.g. > > > User-Agent, Accept and Host can very well be kept, perhaps Connection: > > > close, too. > > > > > > Ideally, the user code should be able to remove/replace these headers if > > > it wants to, but use the default values if nothing is changed. But that > > > requires a bit more complex data structure... Perhaps that's out of scope > > > here, too. > > > > Agreed, it will take quite a bit of work. The current method is > > quick-n-dirty, but functional. > > > > It might be a good idea to introduce some more flexibility into this > > anyway -- I still haven't built a way to disable chunked encoding. > > Another small ff_http method setting a context flag will do the trick, > > but if we want to build something a little more flexible for all this, > > now is the time to do it. AVOptions maybe? > > I think ff_http_* functions for setting both custom headers and disabling > chunked transfer-encoding is ok for now, otherwise you'll end up > refactoring way too much without getting ahead at the actual task at hand.
if a hack is choosen, instead of a proper solution, choose the simplest please. I much prefer 2 http specific flags over 2 http specific functions with delay init flag and what else becomes needed that we then all must throw away once its implemented through AVOptions. [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are too smart to engage in politics are punished by being governed by those who are dumber. -- Plato
signature.asc
Description: Digital signature
_______________________________________________ FFmpeg-soc mailing list [email protected] https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-soc
