On 06/24/2010 10:31 AM, Josh Allmann wrote: > On 24 June 2010 00:14, Martin Storsjö <[email protected]> wrote: >> On Wed, 23 Jun 2010, Josh Allmann wrote: >> >>> Awesome -- patch 002 in this series also replaces memchr with strspn, >>> as noted by Michael and Ronald. >> >> This looks good to me (using #1 and #2 from the later mail). When moving >> sdp_parse_fmtp_config from rtsp.c to to be called parse_sdp_line in >> rtpdec_mpeg4, you could reindent the second parameter line right there >> instead of doing it in patch #7. >> > > Fixed. > >> Except that, this looks good to me. Ronald, Luca, any other opinions, or >> is this good to go? >> > > Sweeet. Updated patchset is properly numbered. >
Two nits 0002 + * MPEG-4 Video RTP callbacks. Might be nice adding the rfc number there as well 0004 +#include <strings.h> string_s_ ? Beside that who tested them? lu -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero _______________________________________________ FFmpeg-soc mailing list [email protected] https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-soc
