On Thu, 1 Jul 2010, Martin Storsjö wrote:
> On Thu, 1 Jul 2010, Martin Storsjö wrote:
>
> > On Thu, 1 Jul 2010, Josh Allmann wrote:
> >
> > > [lots of things fixed]
> >
> > Looks good to me, both of them. The long line in the doxy at the beginning
> > could be wrapped, and if we'd want to be really pedantic, we perhaps
> > should set extradata_size to 0 after av_freep(), since otherwise we could
> > end up with extradata == NULL, but extradata_size > 0 in some situations,
> > which perhaps could make other codepaths crash.
> >
> > But no need to resend another patch with those changes now, I'll make the
> > changes when I apply them.
>
> Actually, the url_close_dyn_buf fix needs a minor adjustment, as in the
> attached patch, I'll squash that in when applying. (I see you didn't
> valgrind your code this time. ;P)
All applied, good job!
// Martin
_______________________________________________
FFmpeg-soc mailing list
[email protected]
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-soc
