Sebastian Vater a écrit :
> Stefano Sabatini a écrit :
>
>
>>
>>
>>> +typedef struct AVSequencerModule {
>>> + /** Metadata information: Original module file name, module name,
>>> + * module message, artist, genre, album, begin and finish date of
>>> + * composition and comment. */
>>> + AVSequencerMetadata *metadata;
>>>
>>>
>> AVSequencerMetadata is not shown in your patches, also I wonder, won't
>> be this a repetition of libavformat AVMetaData?
>>
Fixed by globally replacing AVSequencerMetadata to AVMetadata, I decided
it's way better to implement the new tags in AVMetadata itself than
duplicating all that stuff. 10l to me...
> Fixed locally.
>
Fixed now in github also.
>
>>
>>
>>> + *
>>> + * @param module the AVSequencerModule to be registered
>>> + * @return >= 0 on success, error code otherwise
>>> + *
>>> + * @NOTE This is part of the new sequencer API which is still under
>>> construction.
>>>
>>>
>> @note (case is meaningful).
>>
>>
>
> Oooops...fixed locally!
>
Fixed now in github also.
> Please note I can't commit fixes to github (see my eMail) anymore since
> git rebase -i! Please see my mail. So for now, fixed only locally.
>
Fixed. ;-)
Please update your repository pointing to
http://github.com/BastyCDGS/ffmpeg-soc
One question though, should I mail such small patches here also, or is
it enough to mention that they are fixed?
--
Best regards,
:-) Basty/CDGS (-:
_______________________________________________
FFmpeg-soc mailing list
[email protected]
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-soc
