On Wed, Jul 07, 2010 at 10:50:16PM +0200, Sebastian Vater wrote: [...] > + /** Player envelope flags. Some sequencers allow envelopes > + to operate in different modes, e.g. different loop types, > + randomization, processing modes which have to be taken > + care specially in the internal playback engine. */ > + int8_t flags; > +#define AVSEQ_PLAYER_ENVELOPE_FLAG_FIRST_ADD 0x01 ///< First process > envelope position then get value > +#define AVSEQ_PLAYER_ENVELOPE_FLAG_NO_RETRIG 0x02 ///< Do not retrigger > envelope on new note playback > +#define AVSEQ_PLAYER_ENVELOPE_FLAG_RANDOM 0x04 ///< Envelope returns > randomized instead of waveform data > +#define AVSEQ_PLAYER_ENVELOPE_FLAG_RND_DELAY 0x08 ///< If randomization > is enabled speed is interpreted as delay > +#define AVSEQ_PLAYER_ENVELOPE_FLAG_BACKWARDS 0x10 ///< Envelope is > currently being played backwards > +#define AVSEQ_PLAYER_ENVELOPE_FLAG_LOOPING 0x20 ///< Envelope is > looping in either sustain or normal mode > +#define AVSEQ_PLAYER_ENVELOPE_FLAG_PINGPONG 0x40 ///< Envelope is doing > ping pong style loop
mostof the flags in your code use signed integers, this seems odd to me shouldnt they all be unsigned? and most fields are fixed size instead of more common short/int, is that intended? [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB There will always be a question for which you do not know the correct awnser.
signature.asc
Description: Digital signature
_______________________________________________ FFmpeg-soc mailing list [email protected] https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-soc
