On 29 July 2010 23:48, Martin Storsjö <[email protected]> wrote: > On Thu, 29 Jul 2010, Josh Allmann wrote: >> >> http://mirrorblender.top-ix.org/peach/bigbuckbunny_movies/big_buck_bunny_480p_stereo.ogg > > Hmm, ffplay has some weird issues with this file on OS X, but if hacked to > request slightly larger YUV overlay buffers from SDL (with a width being a > multiple of 16), it works fine. >
Works well on linux. >> >> Using Theora and Vorbis together with RTSP/RTP, things work well. >> >> Theora standalone is still full of artifacts around motion with TCP, >> >> and UDP is a slideshow because of all the dropped packets. Tomorrow, >> >> I'll copy over the packetization routine from Feng and see if the >> >> results are more sane. >> > >> > Hmm, that sounds really strange. Can you give the command lines that >> > you've used for these test setups? >> > >> >> ffmpeg -re -i acodec copy -vcodec copy -f rtsp rtsp://localhost/foo.sdp >> >> also with -an, -vn, and ?tcp variants. >> >> ffplay rtsp://localhost/foo.sdp > > Hmm, that's weird, Theora works just fine over TCP for me. Over UDP, I get > lots of artefacts due to dropped packets, though, but that's probably to > be expected. Tested it with the latest patch you sent (and with the > previous one with my local modifications). > I don't know exactly what I did, but this round adds in support for multiple Xiph frames per packet, and the tcp issue is gone. Pebkac most likely. The r23231 bug with ogg stream copy/Vorbis pts is still there, but that's outside the scope of this patch. Josh
From 05d5d955a34c5cd395bcfdd5f67931b814cf8d58 Mon Sep 17 00:00:00 2001 From: Josh Allmann <[email protected]> Date: Thu, 29 Jul 2010 04:09:29 -0700 Subject: [PATCH] Add RTP packetization of Theora and Vorbis. --- libavformat/Makefile | 1 + libavformat/rtpenc.c | 15 ++++++ libavformat/rtpenc.h | 1 + libavformat/rtpenc_xiph.c | 117 +++++++++++++++++++++++++++++++++++++++++++++ libavformat/rtsp.c | 2 +- libavformat/sdp.c | 108 +++++++++++++++++++++++++++++++++++++++++ 6 files changed, 243 insertions(+), 1 deletions(-) create mode 100644 libavformat/rtpenc_xiph.c diff --git a/libavformat/Makefile b/libavformat/Makefile index f73bc54..16aa0c7 100644 --- a/libavformat/Makefile +++ b/libavformat/Makefile @@ -219,6 +219,7 @@ OBJS-$(CONFIG_RTP_MUXER) += rtp.o \ rtpenc_mpv.o \ rtpenc.o \ rtpenc_h264.o \ + rtpenc_xiph.o \ avc.o OBJS-$(CONFIG_RTSP_DEMUXER) += rtsp.o httpauth.o OBJS-$(CONFIG_RTSP_MUXER) += rtsp.o rtspenc.o httpauth.o diff --git a/libavformat/rtpenc.c b/libavformat/rtpenc.c index 4453f65..1f5bca7 100644 --- a/libavformat/rtpenc.c +++ b/libavformat/rtpenc.c @@ -53,6 +53,8 @@ static int is_supported(enum CodecID id) case CODEC_ID_MPEG2TS: case CODEC_ID_AMR_NB: case CODEC_ID_AMR_WB: + case CODEC_ID_VORBIS: + case CODEC_ID_THEORA: return 1; default: return 0; @@ -135,6 +137,14 @@ static int rtp_write_header(AVFormatContext *s1) s->nal_length_size = (st->codec->extradata[4] & 0x03) + 1; } break; + case CODEC_ID_VORBIS: + case CODEC_ID_THEORA: + if (!s->max_frames_per_packet) s->max_frames_per_packet = 15; + s->max_frames_per_packet = av_clip(s->max_frames_per_packet, 1, 15); + s->max_payload_size -= 6; // ident+frag+tdt/vdt+pkt_num+pkt_length + s->num_frames = 0; + if (st->codec->codec_id == CODEC_ID_VORBIS) goto defaultcase; + break; case CODEC_ID_AMR_NB: case CODEC_ID_AMR_WB: if (!s->max_frames_per_packet) @@ -155,6 +165,7 @@ static int rtp_write_header(AVFormatContext *s1) case CODEC_ID_AAC: s->num_frames = 0; default: +defaultcase: if (st->codec->codec_type == AVMEDIA_TYPE_AUDIO) { av_set_pts_info(st, 32, 1, st->codec->sample_rate); } @@ -393,6 +404,10 @@ static int rtp_write_packet(AVFormatContext *s1, AVPacket *pkt) case CODEC_ID_H263P: ff_rtp_send_h263(s1, pkt->data, size); break; + case CODEC_ID_VORBIS: + case CODEC_ID_THEORA: + ff_rtp_send_xiph(s1, pkt->data, size); + break; default: /* better than nothing : send the codec raw data */ rtp_send_raw(s1, pkt->data, size); diff --git a/libavformat/rtpenc.h b/libavformat/rtpenc.h index 95e70c1..d5d8b99 100644 --- a/libavformat/rtpenc.h +++ b/libavformat/rtpenc.h @@ -67,5 +67,6 @@ void ff_rtp_send_h263(AVFormatContext *s1, const uint8_t *buf1, int size); void ff_rtp_send_aac(AVFormatContext *s1, const uint8_t *buff, int size); void ff_rtp_send_amr(AVFormatContext *s1, const uint8_t *buff, int size); void ff_rtp_send_mpegvideo(AVFormatContext *s1, const uint8_t *buf1, int size); +void ff_rtp_send_xiph(AVFormatContext *s1, const uint8_t *buff, int size); #endif /* AVFORMAT_RTPENC_H */ diff --git a/libavformat/rtpenc_xiph.c b/libavformat/rtpenc_xiph.c new file mode 100644 index 0000000..989354f --- /dev/null +++ b/libavformat/rtpenc_xiph.c @@ -0,0 +1,117 @@ +/* + * RTP packetization for Xiph audio and video + * Copyright (c) 2010 Josh Allmann + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * FFmpeg is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with FFmpeg; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#include "avformat.h" +#include "rtpenc.h" + +/** + * Packetize Xiph frames into RTP according to + * RFC 5215 (Vorbis) and the Theora RFC draft. + * (http://svn.xiph.org/trunk/theora/doc/draft-ietf-avt-rtp-theora-00.txt) + */ +void ff_rtp_send_xiph(AVFormatContext *s1, const uint8_t *buff, int size) +{ + RTPMuxContext *s = s1->priv_data; + int max_pkt_size, xdt, frag; + uint8_t *q; + + max_pkt_size = s->max_payload_size; + + /* set xiph data type */ + switch (*buff) { + case 0x01: // vorbis id + case 0x05: // vorbis setup + case 0x80: // theora header + case 0x82: // theora tables + xdt = 1; // packed config payload + break; + case 0x03: // vorbis comments + case 0x81: // theora comments + xdt = 2; // comment payload + break; + default: + xdt = 0; // raw data payload + } + + /* Set ident. Must match the one in sdp.c + * Probably need a non-fixed way of generating + * this, but it has to be done in SDP and passed in from there. */ + q = s->buf; + *q++ = 0xfe; + *q++ = 0xcd; + *q++ = 0xba; + + /* set fragment + * 0 - whole frame (possibly multiple frames) + * 1 - first fragment + * 2 - fragment continuation + * 3 - last fragmement */ + frag = size <= max_pkt_size ? 0 : 1; + + if (s->num_frames && (xdt || frag)) { + /* immediately send any buffered frames + * if buffer is not raw data, or if current frame is fragmented. */ + ff_rtp_send_data(s1, s->buf, s->buf_ptr - s->buf, 0); + } + + if (!frag && !xdt) { // do we have a whole frame of raw data? + int remaining = max_pkt_size - ((int)(s->buf_ptr - s->buf) + size); + if (remaining < 0 || s->num_frames >= s->max_frames_per_packet) { + /* send previous packets now; no room for new data */ + ff_rtp_send_data(s1, s->buf, s->buf_ptr - s->buf, 0); + s->num_frames = 0; + } + + /* buffer current frame to send later */ + if (0 == s->num_frames) s->timestamp = s->cur_timestamp; + s->num_frames++; + *q++ = s->num_frames; // set packet header + if (s->num_frames > 1) q = s->buf_ptr; // jump ahead if needed + *q++ = (size >> 8) & 0xff; + *q++ = size & 0xff; + memmove(q, buff, size); + q += size; + s->buf_ptr = q; + return; + } + + s->timestamp = s->cur_timestamp; + s->num_frames = 0; + s->buf_ptr = q; + while (size > 0) { + int len = (!frag || frag == 3) ? size : max_pkt_size; + q = s->buf_ptr; + + /* set packet headers */ + *q++ = (frag << 6) | (xdt << 4); + *q++ = (len >> 8) & 0xff; + *q++ = len & 0xff; + /* set packet body */ + memmove(q, buff, len); + q += len; + buff += len; + size -= len; + + ff_rtp_send_data(s1, s->buf, q - s->buf, 0); + + frag = size <= max_pkt_size ? 3 : 2; + } +} diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 689ad29..1be3cd0 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -52,7 +52,7 @@ int rtsp_default_protocols = (1 << RTSP_LOWER_TRANSPORT_UDP); #define SELECT_TIMEOUT_MS 100 #define READ_PACKET_TIMEOUT_S 10 #define MAX_TIMEOUTS READ_PACKET_TIMEOUT_S * 1000 / SELECT_TIMEOUT_MS -#define SDP_MAX_SIZE 8192 +#define SDP_MAX_SIZE 16384 static void get_word_until_chars(char *buf, int buf_size, const char *sep, const char **pp) diff --git a/libavformat/sdp.c b/libavformat/sdp.c index b34b944..acd954a 100644 --- a/libavformat/sdp.c +++ b/libavformat/sdp.c @@ -21,6 +21,7 @@ #include <string.h> #include "libavutil/avstring.h" #include "libavutil/base64.h" +#include "libavcodec/xiph.h" #include "avformat.h" #include "internal.h" #include "avc.h" @@ -220,6 +221,68 @@ static char *extradata2config(AVCodecContext *c) return config; } +static char *xiph_extradata2config(AVCodecContext *c) +{ + char *config, *encoded_config; + uint8_t *header_start[3]; + int headers_len, header_len[3], config_len; + int first_header_size; + + switch (c->codec_id) { + case CODEC_ID_THEORA: + first_header_size = 42; + break; + case CODEC_ID_VORBIS: + first_header_size = 30; + break; + default: + av_log(c, AV_LOG_ERROR, "Unsupported Xiph codec ID\n"); + return NULL; + } + + if (ff_split_xiph_headers(c->extradata, c->extradata_size, + first_header_size, header_start, + header_len) < 0) { + av_log(c, AV_LOG_ERROR, "Extradata corrupt."); + return NULL; + } + + headers_len = header_len[0]+header_len[2]; + config_len = 4 + // count + 3 + // ident + 2 + // packet size + 1 + // header count + 2 + // header size + headers_len; // and the rest + config = av_malloc(config_len); + encoded_config = av_malloc(AV_BASE64_SIZE(config_len)); + + if (!config || !encoded_config) { + av_log(c, AV_LOG_ERROR, + "Not enough memory for configuration string\n"); + return NULL; + } + + config[0] = config[1] = config[2] = 0; + config[3] = 1; + config[4] = 0xfe; // ident must match the one in rtpenc_xiph.c + config[5] = 0xcd; + config[6] = 0xba; + config[7] = (headers_len >> 8) & 0xff; + config[8] = headers_len & 0xff; + config[9] = 2; + config[10] = header_len[0]; + config[11] = 0; // size of comment header; nonexistent + memcpy(config + 12, header_start[0], header_len[0]); + memcpy(config + 12 + header_len[0], header_start[2], header_len[2]); + + av_base64_encode(encoded_config, AV_BASE64_SIZE(config_len), + config, config_len); + av_free(config); + + return encoded_config; +} + static char *sdp_write_media_attributes(char *buff, int size, AVCodecContext *c, int payload_type) { char *config = NULL; @@ -297,6 +360,51 @@ static char *sdp_write_media_attributes(char *buff, int size, AVCodecContext *c, payload_type, c->sample_rate, c->channels, payload_type); break; + case CODEC_ID_VORBIS: + if (c->extradata_size) + config = xiph_extradata2config(c); + else + av_log(c, AV_LOG_ERROR, "Vorbis configuration info missing\n"); + if (!config) + return NULL; + + av_strlcatf(buff, size, "a=rtpmap:%d vorbis/%d/%d\r\n" + "a=fmtp:%d configuration=%s\r\n", + payload_type, c->sample_rate, c->channels, + payload_type, config); + break; + case CODEC_ID_THEORA: { + const char *pix_fmt; + if (c->extradata_size) + config = xiph_extradata2config(c); + else + av_log(c, AV_LOG_ERROR, "Theora configuation info missing\n"); + if (!config) + return NULL; + + switch (c->pix_fmt) { + case PIX_FMT_YUV420P: + pix_fmt = "YCbCr-4:2:0"; + break; + case PIX_FMT_YUV422P: + pix_fmt = "YCbCr-4:2:2"; + break; + case PIX_FMT_YUV444P: + pix_fmt = "YCbCr-4:4:4"; + break; + default: + av_log(c, AV_LOG_ERROR, "Unsupported pixel format.\n"); + return NULL; + } + + av_strlcatf(buff, size, "a=rtpmap:%d theora/90000\r\n" + "a=fmtp:%d delivery-method=inline; " + "width=%d; height=%d; sampling=%s; " + "configuration=%s\r\n", + payload_type, payload_type, + c->width, c->height, pix_fmt, config); + break; + } default: /* Nothing special to do here... */ break; -- 1.7.0.4
_______________________________________________ FFmpeg-soc mailing list [email protected] https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-soc
