Hi,

On Aug 21, 2010, at 6:52 AM, Diego Biurrun <[email protected]> wrote:
> On Fri, Aug 20, 2010 at 11:58:35AM +0530, Mohamed Naufal wrote:
>> 
>> --- a/libavcodec/g723_1.c
>> +++ b/libavcodec/g723_1.c
>> +
>> +    if(!odd_frame) {
> 
> if (
> 
> Please review all your code so that it conforms to K&R style.
> 
>> +        if (pitch_lag == PITCH_MIN)
>> +            pitch_lag++;
>> +        else
>> +            pitch_lag = FFMIN(pitch_lag, PITCH_MAX - 5);
>> +    }
> 
> pointless {}

No, without it gcc won't know which if the else applies to.

Ronald
_______________________________________________
FFmpeg-soc mailing list
[email protected]
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-soc

Reply via email to