#11268: [Regression] "-use_wallclock_as_timestamps" ineffective
------------------------------------+----------------------------------
Reporter: Wes Castro | Owner: (none)
Type: defect | Status: closed
Priority: important | Component: ffmpeg
Version: git-master | Resolution: fixed
Keywords: | Blocked By:
Blocking: | Reproduced by developer: 1
Analyzed by developer: 1 |
------------------------------------+----------------------------------
Comment (by MasterQuestionable):
͏ The peculiar writing for boolean interpretation coercion:
͏ `!!(d->f.ctx->iformat->flags & AVFMT_NOTIMESTAMPS)`
͏ etc.
͏ .
͏ Probably would be better rewritten as:
͏ [ ↓ Needs "`#include <stdbool.h>`". ]
͏ `(bool) ( d->f.ctx->iformat->flags & AVFMT_NOTIMESTAMPS )`
͏ Also "`!!`" on already boolean ("is_unreliable") would be
meaningless.
͏ (even somewhat code obfuscation)
\\
͏ Code style recommendation:
͏ `!!is_unreliable`
͏ `!!( ist->fix_sub_duration )`
͏ `(bool) is_unreliable`
͏ `(bool) ( ... )`
--
Ticket URL: <https://trac.ffmpeg.org/ticket/11268#comment:3>
FFmpeg <https://ffmpeg.org>
FFmpeg issue tracker
_______________________________________________
FFmpeg-trac mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-trac
To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".
