On 2017-12-07 00:08, Jon bae wrote:
Hello,
on Monday I send a little patch for the *vf_blackdetect.c* filter to the
dev list, but I don't got any response. I don't wanted to sound impatient,
I just want to know that I did everything right.
One thing is to, that my patch is not shown here:
https://patchwork.ffmpeg.org/project/ffmpeg/list/ so I though maybe I did
something wrong.
For generating the patch I use *git format-patch, *send-mail is not working
on my computer, so I send the patch as an attachment.
I send the patch from gmail, is this a problem?
Is there something specific, I need to know about sending the patch per
mail? (yes I read the page step 6: Submitting patches).
This was the Mail:
http://ffmpeg.org/pipermail/ffmpeg-devel/2017-December/221698.html
Jonathon:
Welcome to ffmpeg! Thank you for taking the time to create a patch and
help make the software better.
You are asking this question on the ffmpeg-user list, but patches are
handled on the ffmpeg-devel list. Are you subscribed to
ffmpeg-de...@ffmpeg.org? That is recommended; see
<http://ffmpeg.org/developer.html#Documentation_002fOther>, heading
about "ffmpeg-devel". If you are subscribed to the list, you can be
sure that your patch came through intact.
You might get better answers on the ffmpeg-devel list, because it is
about patches. ffmpeg-user is about using ffmpeg, which is a different
topic.
I see three messages from you about "Patch vf_blackdetect" to ffmpeg-devel:
[1] <http://ffmpeg.org/pipermail/ffmpeg-devel/2017-December/221689.html>
"Here's a patch"
[2] <http://ffmpeg.org/pipermail/ffmpeg-devel/2017-December/221698.html>
"Here's a patch which works"
[3] <http://ffmpeg.org/pipermail/ffmpeg-devel/2017-December/221691.html>
"Please forget the last patch"
I can imagine someone reading these three messages and thinking, this
patch isn't ready.
When you have a new patch, it's good to include "v2" (or "v3", "v4", as
necessary) in the patch summary to indicate version 2, 3, 4 of the patch.
Also, use the --in-reply-to option of git format-patch to specify the
Message-Id of the message with the previous version of the patch. This
makes your new patch a child of the previous patch in the list message
thread. You did that with [2], so maybe you know about this option.
Just to check: did you recompile ffmpeg with your patch? Did you run
all the FATE tests?
Is there already a test in FATE for the change you made? If not,
consider adding a FATE test. It will prove your change works.
I hope this is helpful. Good luck with the patch,
—Jim DeLaHunt
--
--Jim DeLaHunt, j...@jdlh.com http://blog.jdlh.com/ (http://jdlh.com/)
multilingual websites consultant
355-1027 Davie St, Vancouver BC V6E 4L2, Canada
Canada mobile +1-604-376-8953
_______________________________________________
ffmpeg-user mailing list
ffmpeg-user@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-user
To unsubscribe, visit link above, or email
ffmpeg-user-requ...@ffmpeg.org with subject "unsubscribe".
