At 23:37 Uhr -0800 04.01.2003, Daniel Parks wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hey,

There seems to be an mistake in either Fink or the documentation about InstallScript, Files, and SplitOff.

According to the documentation, Files is supposed to run after the InstallScript of the parent package, but before the InstallScript of the SplitOff. In reality, Fink runs Files after the InstallScript in the SplitOff.
Didn't even know that we documented the order in which they are executed. But yeah, the Files field is treated after the InstallScript of the splitoff was run. Relevant code is in PkgVersion.pm, around lines 1272 and 1294.


Personally, I like the idea of being able to copy files into a SplitOff, then deal with them as I see fit in a InstallScript. For example:

SplitOff: <<
Package: %N-shlibs
Files: lib/lib%N.1.1.dylib
InstallScript: ln -s lib%n.1.1.dylib %i/lib/lib%N.1.dylib
<<

I don't seem much point in running InstallScript: before Files:, there is an argument for not running InstallScript: at all in SplitOffs.

I agree that it would probably be more logical to have Files: run before the InstallScript: of the splitoff. But in fact I think a splitoff should never need an installscript, and I can't think of a single reason why one would need a seperate installscript for a splitoff. So we might just not run the installscript at all for a splitoff.

In any case, before either change could be made, one must check if any package currently uses an InstallScript inside a splitoff. If there are any, it must be verified that the change will not break that package. If the change would break that package, we either can't make the change, or have to come up with a way to make the transition as smooth as possible.



Cheers,

Max
--
-----------------------------------------------
Max Horn
Software Developer


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Fink-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/fink-devel


Reply via email to