From: Daniel Macks <[EMAIL PROTECTED]>
===================================================================
RCS file: /cvsroot/fink/fink/perlmod/Fink/PkgVersion.pm,v
diff -u -d -r1.211 -r1.212
@@ -1595,10 +1600,15 @@
} elsif (!exists $self->{parent} and $self->param("_type") eq "perl") {
# grab perl version, if present
my ($perldirectory, $perlarchdir) = $self->get_perl_dir_arch();
$install_script .=
"make install PREFIX=\%i INSTALLPRIVLIB=\%i/lib/perl5$perldirectory INSTALLARCHLIB=\%i/lib/perl5$perldirectory/$perlarchdir INSTALLSITELIB=\%i/lib/perl5$perldirectory INSTALLSITEARCH=\%i/lib/perl5$perldirectory/$perlarchdir INSTALLMAN1DIR=\%i/share/man/man1 INSTALLMAN3DIR=\%i/share/man/man3 INSTALLSITEMAN1DIR=\%i/share/man/man1 INSTALLSITEMAN3DIR=\%i/share/man/man3 INSTALLBIN=\%i/bin INSTALLSITEBIN=\%i/bin INSTALLSCRIPT=\%i/bin\n";
+ } elsif ($self->param("_type") eq "ruby") {
+ # grab ruby version, if present
+ my ($rubydirectory, $rubyarchdir) = $self->get_ruby_dir_arch();
+
+ $install_script .= "make install prefix=\%i\n";
} elsif (not $do_splitoff) {
$install_script .= "make install prefix=\%i\n";
}
What is the effect of get_ruby_dir_arch() here (i.e., why are you handling type:ruby separately)? But more importantly, it appears you are having the default action to be "make install" even in a SplitOff of a type:ruby package. That seems bad.
You're absolutely right. I think I introduced that code because I initially expected having to add lots of variable overrides like the Perl version does, and because everything worked, I never revisited that assumption.
I'll fix this ASAP (although I don't expect to see splitoffs from ruby packages anytime soon :-)
Matthias
------------------------------------------------------- The SF.Net email is sponsored by EclipseCon 2004 Premiere Conference on Open Tools Development and Integration See the breadth of Eclipse activity. February 3-5 in Anaheim, CA. http://www.eclipsecon.org/osdn _______________________________________________ Fink-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/fink-devel
