Hi,

I'm really new to FiPy, so I apologize if my questions are a bit naive.

I'm having problems passing the doctests in fipy. I think most of the problems stem from changes in numpy 1.0.4, some of which are addressed by changeset 2455. I tried downloading CURRENT from the svn tree (changeset 2480), but strangely the changes from 2455 are not incorporated. Even with the changes, I still run into problems:

Many of the examples fail due to changes to numpy's masked arrays. Without the changes to fipy.meshes.numMesh.mesh from changeset 2455, I get a
    NotImplementedError: not yet implemented for numpy.ma arrays
After adding the changes from changeset 2455, I get
    'IndexError: invalid index'
I was just messing around with the code and it turns out that changing (see changeset 2455)
    other.faceVertexIDs[...,i]
to
    other.faceVertexIDs[i]
(Note, removal of ellipsis) resulted in passing tests. However, I don't feel comfortable with this change since I don't really know what's going on with the code.

Also, I had some small problems with spacing of the doctest results (most likely due to changes in printing output in numpy 1.0.4) in fipy.tools.dimensions.physicalField. Of course, making these changes would mean breaking tests for older versions of numpy.

After all these changes, all tests pass (except a few ValueErrors in fipy.variables.variable.Variable.__array__, as noted in the installation page). I just wanted to make sure that I won't be breaking something if I make these changes.

Thanks,
-Tony

FYI:
Mac OS X 10.5
numpy 1.0.4
scipy 0.6.0
python 2.5.1
FiPy 1.2


Reply via email to