> 18 дек. 2014 г., в 11:35, Roman Simakov <roman.sima...@gmail.com> написал(а): > > Alex, > > I'd recommend you to prepare ONE good patch for good goal, send it as > file ready for applying, explain why, etc > AFAIU your message are generate automatically. But they must be read, > analyzed and applied by people. > Think about reviewers and they will think about you :)
Ah sorry guys! Other projects where I’m contribute patches prefer to send patches in mail body and one patch by issue. > > 2014-12-18 11:30 GMT+03:00 Alexey Pavlov <alex...@gmail.com>: >> From 99c644e7ae0a87573f51d088973e6e43da944e2b Mon Sep 17 00:00:00 2001 >> From: Alexpux <alexey.paw...@gmail.com> >> Date: Thu, 20 Nov 2014 20:17:46 +0300 >> Subject: [PATCH] Mingw don't support Win98. >> >> --- >> src/common/classes/locks.cpp | 2 ++ >> src/common/os/win32/guid.cpp | 2 ++ >> 2 files changed, 4 insertions(+) >> >> diff --git a/src/common/classes/locks.cpp b/src/common/classes/locks.cpp >> index 5a44ad4..68b64d6 100644 >> --- a/src/common/classes/locks.cpp >> +++ b/src/common/classes/locks.cpp >> @@ -25,7 +25,9 @@ >> * Contributor(s): ______________________________________. >> */ >> >> +#ifndef __MINGW32__ >> #define _WIN32_WINNT 0x0403 >> +#endif >> >> #include "firebird.h" >> >> diff --git a/src/common/os/win32/guid.cpp b/src/common/os/win32/guid.cpp >> index 63c6214..0bebe42 100644 >> --- a/src/common/os/win32/guid.cpp >> +++ b/src/common/os/win32/guid.cpp >> @@ -26,8 +26,10 @@ >> * >> */ >> >> +#ifndef __MINGW32__ >> // minimum win32 version: win98 / winnt4 SP3 >> #define _WIN32_WINNT 0x0403 >> +#endif >> >> #include <windows.h> >> #include <wincrypt.h> >> -- >> 2.2.0 >> >> >> ------------------------------------------------------------------------------ >> Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server >> from Actuate! Instantly Supercharge Your Business Reports and Dashboards >> with Interactivity, Sharing, Native Excel Exports, App Integration & more >> Get technology previously reserved for billion-dollar corporations, FREE >> http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk >> Firebird-Devel mailing list, web interface at >> https://lists.sourceforge.net/lists/listinfo/firebird-devel >> > > > > -- > Roman Simakov > > ------------------------------------------------------------------------------ > Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server > from Actuate! Instantly Supercharge Your Business Reports and Dashboards > with Interactivity, Sharing, Native Excel Exports, App Integration & more > Get technology previously reserved for billion-dollar corporations, FREE > http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk > Firebird-Devel mailing list, web interface at > https://lists.sourceforge.net/lists/listinfo/firebird-devel ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
