On 10/25/2015 03:46 PM, Mark Rotteveel wrote:
> I am looking at the init method in interface.cpp, and I see this:
>
> if (port->port_protocol < PROTOCOL_VERSION12)
> {
>       // This is FB < 2.5. Lets remove that not recognized DPB/SPB and
> convert the UTF8
>       // strings to the OS codepage.
>       intlParametersBlock.fromUtf8(dpb, isc_dpb_utf8_filename);
>       ISC_unescape(file_name);
>       ISC_utf8ToSystem(file_name);
> }
>
> As this method is called for both database attach/create and service
> attach, shouldn't the "isc_dpb_utf8_filename" from
> "intlParametersBlock.fromUtf8(dpb, isc_dpb_utf8_filename);" be an
> spb/dpb independent reference (eg using the ParameterSet)? Or better
> yet: shouldn't this be handled in the implementation of IntlParametersBlock?

You are absolutely right - done.


------------------------------------------------------------------------------
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel

Reply via email to