Hi, i know that team is now very busy - today released RC1..
but i have 3 questions 1. I fix some output indentation and i have removed Index name quotation and i put patch file on own server http://itstop.pl/SVNFB/FB3.patch but is this good code formating and conversion? (changes in jrd/recsrc/RecordSource.cpp) bounds.printf( (printIndent(level, detailed_format) + "<Bounds>" + printIndent(level+1, detailed_format) + "<lower_bound>%d/%d</lower_bound>" + printIndent(level, detailed_format) + "</Bounds>").c_str(), retrieval->irb_lower_count, segCount); 2. Is this pull request useful at all or this is useless for FB team? I try to start to teach FB code, to work in the future on more useful and harder topics. But i must get start point, will be good to see feedback (and also criticism) 3. If answer for 2 is Yes - then do you think that "Access By ID" should be printed as separated Node Operation instead of attribute? regards, Karol Bieniaszewski -----Oryginalna wiadomość----- From: Adriano dos Santos Fernandes Sent: Sunday, November 08, 2015 7:11 PM To: For discussion among Firebird Developers Subject: Re: [Firebird-devel] Pull request fixed (explained plan xml format) Personally, I prefer much more XML than "another internal format just for display purposes". Adriano ------------------------------------------------------------------------------ Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel