Thanks for such a quick response! I've made the change and it seems to work
perfectly, and I've submitted a (very brief) pull request for it.

-Robin

On Wed, Jun 6, 2012 at 7:38 PM, ridiculous_fish <
[email protected]> wrote:

> Hi Robin,
>
> I tracked down the problem. There's no simple fix from a fish function,
> but if you're willing to rebuild fish it can be fixed.
>
> In reader.cpp, look for this line:
>
>   writestr( L"\x1b]2;" );
>
> Replace that 2 with a 1 or 0. They have the following significance:
>
> 2: Window title
> 1: Tab title
> 0: Both window and tab title
>
> Probably we should just remove the 2…I think if we omit the number it's
> the same as setting 0.
>
> Thanks for the bug report! I captured this in
> https://github.com/ridiculousfish/fishfish/issues/47 - feel free to
> comment there.
>
> _fish
>
> On Jun 6, 2012, at 3:48 PM, Robin Deits wrote:
>
> > Hello all,
> >
> > I'm just starting out with fishfish, and it's fantastic. However, I
> can't figure out how to set my tab titles in iTerm2 on OSX. I've got
> fish_title set up as:
> >
> > function fish_title
> >       echo Foo
> > end
> >
> > This successfully turns my Terminal.app window *and* tab titles to
> "Foo", and it also turns my iTerm2 window title to "Foo" . It will not,
> however, change my iTerm2 tab titles (they're still "Shell"), which is
> actually the only thing I care about. Has anyone been able to get this
> working?
> >
> > In bash, I had the following prompt setting, which did correctly set the
> iTerm2 tab titles:
> > export PS1="\[\e[0;32m\]\u@\h: \w\n\[\e[0m\]$ \[\033]0;\W\007\]"
> >
> > Thanks!
> > -Robin
>
>
>
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Fish-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fish-users

Reply via email to