By that I mean, anywhere that MM:SS:FF is accepted, so is MM:SS (whose meaning 
is MM:SS:00) , and further, allowing MM:SS to be used regardless of the sample 
rate.  Then the MM:SS:00 special case can be removed; the user will always use 
MM:SS when the sample rate is not 44100.  The tests probably also have to be 
augmented to cover MM:SS, and possibly the man page and html docs.




>________________________________
> From: Earl Chew <earl_c...@yahoo.com>
>To: Josh Coalson <xf...@yahoo.com>; "flac-dev@xiph.org" <flac-dev@xiph.org> 
>Sent: Wednesday, May 2, 2012 11:13 AM
>Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to 
>completion
> 
>
>Josh,
>
>
>Sure. I can try. Would you give me a more detailed description of the 
>requirement ?
>
>
>What exactly does "general MM:SS handling" mean ?
>
>
>Earl
>
>
>
>
>________________________________
> From: Josh Coalson <xf...@yahoo.com>
>To: Earl Chew <earl_c...@yahoo.com>; "flac-dev@xiph.org" <flac-dev@xiph.org> 
>Sent: Tuesday, May 1, 2012 8:25:34 PM
>Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to 
>completion
> 
>
>Ah, I don't remember but it might have been a negative test that was supposed 
>to give an error when used with the wrong sample rate.
>
>
>Anyway, could you do another patch that updates to general MM:SS handling?
>
>
>
>
>>________________________________
>> From: Earl Chew <earl_c...@yahoo.com>
>>To: Josh Coalson <xf...@yahoo.com>; "flac-dev@xiph.org" <flac-dev@xiph.org> 
>>Sent: Thursday, April 26, 2012 3:12 PM
>>Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to 
>>completion
>> 
>>
>>Josh,
>>
>>
>>I see my name is mentioned in passing ;-)
>>
>>
>>I submitted that patch because I thought it preferable to keep the test 
>>harness running.
>>
>>
>>Backing this change out would also entail changing metaflac_test.sh 
>>accordingly, which at the time, I was hesitant to do.
>>At the time I figured that at some point metaflac_test.sh was passing, so the 
>>code should probably allow it to pass.
>>
>>
>>I'm ok either way.
>>
>>
>>
>>Earl
>>
>>
>>
>>________________________________
>> From: Josh Coalson <xf...@yahoo.com>
>>To: "flac-dev@xiph.org" <flac-dev@xiph.org> 
>>Sent: Wednesday, April 25, 2012 3:23:35 PM
>>Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to 
>>completion
>> 
>>
>>I haven't checked git yet but I hope this patch has not gone in.  I don't 
>>like the special case that this is creating.
>>
>>
>>It would be better to allow MM:SS everywhere but I consider that low priority.
>>
>>
>>
>>
>>>________________________________
>>> From: Earl Chew <earl_c...@yahoo.com>
>>>To: "flac-dev@xiph.org" <flac-dev@xiph.org> 
>>>Sent: Thursday, January 5, 2012 8:27 PM
>>>Subject: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to 
>>>completion
>>> 
>>>
>>>When reading the INDEX from the cue sheet, the format MM:SS:FF format is 
>>>disallowed if the sample frequency is not a multiple of 75 because the index 
>>>would only be approximate. However, 00:00:00 is _exact_ because it denotes 
>>>the start of the track, so allow it as a special case. This allows 
>>>metaflac_test.sh to pass.
>>>
>>>
>>>_______________________________________________
>>>flac-dev mailing list
>>>flac-dev@xiph.org
>>>http://lists.xiph.org/mailman/listinfo/flac-dev
>>>
>>>
>>>
>>_______________________________________________
>>flac-dev mailing list
>>flac-dev@xiph.org
>>http://lists.xiph.org/mailman/listinfo/flac-dev
>>
>>
>>
>>
>>
>
>
>
>
_______________________________________________
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Reply via email to