On 16.09.2009 06:25, Paul Fox wrote: > carl-daniel wrote: > > [Paul, I included you in CC because you wrote the ft2232 code.] > > thanks carl. >
Thanks for commenting. By the way, are you using plain flashrom from svn at OLPC or do you have any local patches applied? > > On 15.09.2009 19:49, Stefan Reinauer wrote: > > > this patch fixes all 27 flashrom source code issues reported by > > > LLVM/clang's scan-build (r79326, new build on the way). > > > > > > Signed-off-by: Stefan Reinauer <[email protected]> > > > > > The following parts of the patch are > > Acked-by: Carl-Daniel Hailfinger <[email protected]> > > > > sst28sf040.c (definitely) > > sharplhf00l04.c (we shouldn't enter ID mode at all) > > stm50flw0x0x.c (we shouldn't enter ID mode at all) > > serprog.c (serprog_die should be killed, but for now...) > > > > > > ft2232_spi.c is a bit special because I don't have any idea what > > port_val is used for. It looks like a dead variable, but maybe it was > > intended to track the status of other lines besides CS# and in that case > > we should keep the variable and fill it with the correct value. > > it looks dead to me. i tracked it back as coming from the bitbang.c > sample code that came (i think) with libftdi, and in my copy of that > code, at least, it's already a useless variable. get rid of it. > Stefan, with that information, the changes in ft2232_spi.c are Acked-by: Carl-Daniel Hailfinger <[email protected]> Regards, Carl-Daniel -- http://www.hailfinger.org/ _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
