On 14.06.2010 16:35, Idwer Vollering wrote: > 2010/6/14 Carl-Daniel Hailfinger <[email protected]> > > >> On 14.06.2010 15:18, Carl-Daniel Hailfinger wrote: >> >>> Handle OS where executables have a hardcoded suffix, e.g. DOS with .exe . >>> This ensures that any temp files in the configure/check step of the >>> Makefile are removed correctly. >>> >>> >> Idwer pointed out that the flashrom Makefile target and a few other >> places were missing executable suffix handling. Fix. >> >> Signed-off-by: Carl-Daniel Hailfinger <[email protected]> >> >> > > Acked-by: Idwer Vollering <[email protected]> >
Thanks, committed in r1047. > With one comment further in this message: > >> Index: flashrom-dos_exec_suffix/Makefile >> =================================================================== >> --- flashrom-dos_exec_suffix/Makefile (Revision 1045) >> +++ flashrom-dos_exec_suffix/Makefile (Arbeitskopie) >> @@ -268,23 +269,24 @@ >> >> # Make sure to add all names of generated binaries here. >> # This includes all frontends and libflashrom. >> +# We don't use EXEC_SUFFIX here because we want to clean everything. >> >> > > It's used everywhere except here ? > Exactly. > Changing "clean" to the syntax below doesn't work as expected anyway: > clean: > - rm -f $(PROGRAM) $(PROGRAM).exe *.o *.d > + rm -f $(PROGRAM) $(PROGRAM)$(EXEC_SUFFIX) *.o *.d > > > $ make distclean > rm -f flashrom flashrom *.o *.d > rm -f .features .libdeps > That's the reason why I didn't change the "clean" target. > clean: > >> rm -f $(PROGRAM) $(PROGRAM).exe *.o *.d >> >> Regards, Carl-Daniel -- http://www.hailfinger.org/ _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
