i have forgot a few tiny bits. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner
>From cbb70afb13193c77e53467ca150e91de794ccc0d Mon Sep 17 00:00:00 2001 In-Reply-To: <[email protected]> References: <[email protected]> From: Stefan Tauner <[email protected]> Date: Tue, 21 Jun 2011 23:00:11 +0200 Subject: [PATCH 4/5] fixup! serprog improvements
Signed-off-by: Stefan Tauner <[email protected]> --- serprog.c | 19 ++++++++++++------- 1 files changed, 12 insertions(+), 7 deletions(-) diff --git a/serprog.c b/serprog.c index 7585baf..30b4c12 100644 --- a/serprog.c +++ b/serprog.c @@ -38,7 +38,7 @@ #include "programmer.h" #include "chipdrivers.h" -#define MSGHEADER "serprog:" +#define MSGHEADER "serprog: " /* * FIXME: This prototype was added to help reduce diffs for the shutdown @@ -399,12 +399,12 @@ int serprog_init(void) msg_pdbg(MSGHEADER "Synchronized\n"); if (sp_docommand(S_CMD_Q_IFACE, 0, NULL, 2, &iface)) { - msg_perr("Error: NAK to Query Interface version\n"); + msg_perr("Error: NAK to query interface version\n"); exit(1); } if (iface != 1) { - msg_perr("Error: Unknown interface version %d\n", iface); + msg_perr("Error: Unknown interface version: %d\n", iface); exit(1); } @@ -423,6 +423,11 @@ int serprog_init(void) c = CHIP_BUSTYPE_NONSPI; /* A reasonable default for now. */ } buses_supported = c; + msg_pdbg(MSGHEADER "Bus support: parallel=%s, LPC=%s, FWH=%s, SPI=%s\n", + (c & CHIP_BUSTYPE_PARALLEL) ? "on" : "off", + (c & CHIP_BUSTYPE_LPC) ? "on" : "off", + (c & CHIP_BUSTYPE_FWH) ? "on" : "off", + (c & CHIP_BUSTYPE_SPI) ? "on" : "off"); /* Check for the minimum operational set of commands. */ if (buses_supported & CHIP_BUSTYPE_SPI) { uint8_t bt = CHIP_BUSTYPE_SPI; @@ -533,12 +538,12 @@ int serprog_init(void) strcpy((char *)pgmname, "(unknown)"); } pgmname[16] = 0; - msg_pinfo(MSGHEADER "Programmer name \"%s\"\n", pgmname); + msg_pinfo(MSGHEADER "Programmer name is \"%s\"\n", pgmname); if (sp_docommand(S_CMD_Q_SERBUF, 0, NULL, 2, &sp_device_serbuf_size)) { msg_perr("Warning: NAK to query serial buffer size\n"); } - msg_pdbg(MSGHEADER "serial buffer size %d\n", + msg_pdbg(MSGHEADER "serial buffer size is %d\n", sp_device_serbuf_size); if (sp_check_commandavail(S_CMD_O_INIT)) { @@ -559,7 +564,7 @@ int serprog_init(void) msg_perr("Warning: NAK to query operation buffer " "size\n"); } - msg_pdbg(MSGHEADER "operation buffer size %d\n", + msg_pdbg(MSGHEADER "operation buffer size is %d\n", sp_device_opbuf_size); } @@ -576,7 +581,7 @@ static void sp_pass_writen(void) { unsigned char header[7]; msg_pspew(MSGHEADER "Passing write-n bytes=%d addr=0x%x\n", - sp_write_n_bytes, sp_write_n_addr); + sp_write_n_bytes, sp_write_n_addr); if (sp_streamed_transmit_bytes >= (7 + sp_write_n_bytes + sp_device_serbuf_size)) sp_flush_stream(); -- 1.7.1
_______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
