On 08/01/2011 06:10 AM, Noé Rubinstein wrote:
Use AAI for some SST chips

Patch updated, based on Joshua Roys' patch
http://patchwork.coreboot.org/patch/2065/
I double checked against the datasheets. Also wrapped the comments to
respect 80-columns line width.

Use AAI:
SST25VF016B
SST25VF040B{,.REMS}
SST25VF080B

Datasheets say AAI is supported, but via a different opcode:
SST25VF040.REMS
SST25LF040A.RES

Signed-off-by: Noé Rubinstein <nrubinst...@avencall.com>

Signed-off-by: Joshua Roys <roysj...@gmail.com>

---
Index: flashchips.c
===================================================================
--- flashchips.c        (revision 1401)
+++ flashchips.c        (working copy)
@@ -5606,7 +5606,7 @@
                        },
                },
                .unlock         = spi_disable_blockprotect,
-               .write          = spi_chip_write_1,
+               .write          = spi_aai_write,
                .read           = spi_chip_read,
                .voltage        = {2700, 3600},
        },
@@ -5708,7 +5708,8 @@
                        },
                },
                .unlock         = spi_disable_blockprotect,
-               .write          = spi_chip_write_1,
+               .write          = spi_chip_write_1, /* datasheet says AAI using
+                                                      0xAF ? */
                .read           = spi_chip_read,
                .voltage        = {2700, 3600},
        },
@@ -5744,7 +5745,7 @@
                        },
                },
                .unlock         = spi_disable_blockprotect,
-               .write          = spi_chip_write_1,
+               .write          = spi_aai_write,
                .read           = spi_chip_read,
                .voltage        = {2700, 3600},
        },
@@ -5774,7 +5775,8 @@
                        },
                },
                .unlock         = spi_disable_blockprotect,
-               .write          = spi_chip_write_1,
+               .write          = spi_chip_write_1, /* datasheet says AAI using
+                                                      0xAF ? */
                .read           = spi_chip_read,
                .voltage        = {3000, 3600},
        },
@@ -5810,7 +5812,7 @@
                        },
                },
                .unlock         = spi_disable_blockprotect,
-               .write          = spi_chip_write_1,
+               .write          = spi_aai_write,
                .read           = spi_chip_read,
                .voltage        = {2700, 3600},
        },
@@ -5846,7 +5848,7 @@
                        },
                },
                .unlock         = spi_disable_blockprotect,
-               .write          = spi_chip_write_1,
+               .write          = spi_aai_write,
                .read           = spi_chip_read,
                .voltage        = {2700, 3600},
        },

_______________________________________________
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom


_______________________________________________
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom

Reply via email to