2012/1/12 Paul Menzel <[email protected]>: > Date: Thu, 12 Jan 2012 01:59:42 +0100 > Subject: [PATCH] flashrom.c: Reorder list of options to test > > If a chip is unknown the user is asked to test and report the result to the > mailing list. Having `-VE` listed as the last option can result in an > unbootable system for users not knowing what the command does, since > rebooting the system after that command is fatal since the flash chip is > empty. [1] > > Reorder the options as a quick fix to prevent that in the future as suggested > by idwer on #flashrom. > > [1] http://www.flashrom.org/pipermail/flashrom/2012-January/008551.html > > Signed-off-by: Paul Menzel <[email protected]> > --- > flashrom.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/flashrom.c b/flashrom.c > index f1a6165..ee68344 100644 > --- a/flashrom.c > +++ b/flashrom.c > @@ -1600,7 +1600,7 @@ void check_chip_supported(const struct flashctx *flash) > "include the flashrom\n" > "output with the additional -V option for all " > "operations you tested (-V, -Vr,\n" > - "-Vw, -VE), and mention which mainboard or " > + "-VE, -Vw), and mention which mainboard or " > "programmer you tested.\n" > "Please mention your board in the subject line. " > "Thanks for your help!\n");
I was thinking of this (see patch), this way flashrom shows verbs (actions) instead of parameters. Signed-off-by: Idwer Vollering <[email protected]> Index: flashrom.c =================================================================== --- flashrom.c (revision 1485) +++ flashrom.c (working copy) @@ -1598,10 +1598,11 @@ "any of the above operations\n" "work correctly for you with this flash part. Please " "include the flashrom\n" - "output with the additional -V option for all " - "operations you tested (-V, -Vr,\n" - "-VE, -Vw), and mention which mainboard or " + "output with the -V option for all " + "operations you tested (verbose, verbose read,\n" + "verbose erase, verbose write), and mention which mainboard or " "programmer you tested.\n" + "The parameters are listed after running 'flashrom --help'\n" "Please mention your board in the subject line. " "Thanks for your help!\n"); } > -- > 1.7.8.3 > > _______________________________________________ > flashrom mailing list > [email protected] > http://www.flashrom.org/mailman/listinfo/flashrom _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
