Am Mittwoch, den 07.03.2012, 01:22 +0100 schrieb Stefan Tauner:
> From 4df237d340416aa424f93ca4a9d9b4dd719ed02f Mon Sep 17 00:00:00 2001
> From: Stefan Tauner <[email protected]>
> Date: Wed, 7 Mar 2012 01:16:11 +0100
> Subject: [PATCH] Add board enable for ASUS TUSL2-C
>
> Primary IDs SMBus controller, Secondary IDs MCH.
> With implicit courtesy of Micheal 'awesome' Kracher :)
My name is "Karcher", not "Kracher". And also it is "Michael", not
"Micheal".
> + {0x8086, 0x2443, 0x1043, 0x8027, 0x8086, 0x1130, 0x1043, 0x8027,
> NULL, NULL, NULL, P3, "ASUS", "TUSL2-C",
> 0, OK, intel_ich_gpio21_raise},
This line looks entirely correct, but you did not care about the "rule
of three" for board enables: A typical board enable patch needs three
hunks, one of them is vital for functionality.
1st: (you have it, it is vital) The board enable table
2nd: The comment with the board list at the enable function,
or the complete enable function, if it is a new one
3rd: The entries in print.c
Regards,
Michael Karcher
_______________________________________________
flashrom mailing list
[email protected]
http://www.flashrom.org/mailman/listinfo/flashrom
