Am Mittwoch, den 18.07.2012, 01:48 +0200 schrieb Carl-Daniel Hailfinger: > get_io_perms() is renamed to rget_io_perms() and automatically registers > a function to release I/O permissions on shutdown. Sounds like a good idea, but what happens if two threads use different programmers, both needing I/O permissions? You would need atomic reference counts on the io permissions to fix that. I don't claim the current code would not fail in spectecular ways on that use, but AFAIK this is something we want to achieve in the long run (see the flashctx stuff for example).
Apart from that, it seems good. Do we want to use the chance and replace the exit(1) in get_io_perms by a return value? > Signed-off-by: Carl-Daniel Hailfinger <[email protected]> Acked-by: Michael Karcher <[email protected]> Regards, Michael Karcher _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
