On Tue, 2012-12-25 at 12:41 +0100, Stefan Tauner wrote:
> On Fri, 16 Nov 2012 22:48:22 +0200
> Kyösti Mälkki <[email protected]> wrote:
> 
> > > diff --git a/programmer.h b/programmer.h
> > > index 9f90fe5..b52727e 100644
> > > --- a/programmer.h
> > > +++ b/programmer.h
> > > @@ -93,15 +93,22 @@ enum programmer_type {
> > >   OTHER,
> > >  };
> > >  
> > > +struct dev_status {
> > > + uint16_t vendor_id;
> > > + uint16_t device_id;
> > > + const enum test_state status;
> > > + const char *vendor_name;
> > > + const char *device_name;
> > > +};  
> > 
> > I find the name "dev_status" odd, these are the arrays for listing
> > and probing the VID/DID too, and the "status" is just documentation.
> 
> i missed this before sending version 5.0 of my patches. you do have a
> point. any suggestions? "dev" might be ok, but it begs for conflicts.
> 

Maybe dev_probe_info or dev_probe ?



_______________________________________________
flashrom mailing list
[email protected]
http://www.flashrom.org/mailman/listinfo/flashrom

Reply via email to