Stefan, I pulled your latest code from https://github.com/stefanct/flashrom/tree/amd. However it's still reading bad bits at 16.5 MHz. Here's a log from -VV trying to erase the flash.
On Fri, Aug 9, 2013 at 12:39 AM, Stefan Tauner <[email protected]> wrote: > On Fri, 9 Aug 2013 00:22:05 -0700 > Wei Hu <[email protected]> wrote: > >> On Thu, Aug 8, 2013 at 11:41 PM, Stefan Tauner >> <[email protected]> wrote: >> >> 1. Your patch defaults SPI clock to 16.5 MHz, which didn't work. I >> >> also found none of 22, 33, 100 MHz worked. Only passing -p >> >> internal:spispeed="66 MHz" worked. >> > >> > Please be more specific and/or attach logs. Did the parsing of the >> > value not work or did the actual register changes not work? >> >> Will attach logs tomorrow when I get to work. To make parsing work I >> had to pass values in quotes like "66 MHz" etc. because you were >> matching the full name. After figuring this part out the actual >> register changes failed at >> msg_perr("Setting SPI clock failed.\n"); > > I have figured it out... I have used the wrong integer types most of the > time, sorry. I have this fixed locally, but want to test it more and > review the whole thing before sending another such nightmare :) > But I can send you the fix in private if you need it faster than that. > > The change that requires to use quotes now was necessary because of the > addition of the "800 kHz" value in Yangtze. Eventually we will add a > generic frequency parser, but until then please just use the quotes. > -- > Kind regards/Mit freundlichen Grüßen, Stefan Tauner
log
Description: Binary data
_______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
