On Tue, 15 Oct 2013 15:30:00 -0400 Cory Henderson <[email protected]> wrote:
> Hi, > > I am new to the mailing list so I am not sure if this is the right place > for these. My company used the SST25VF512A in a project and I was able to > configure flashrom to work with this chip using a buspirate (HW v3.5, FW > v6.2 beta). The chip was already listed in flashchips.h so I just added the > proper information to flashchips.c. Probe, read, write, and erase all work > fine for me, albeit slowly because the AAI supported by the chip uses a > different command than the one used in flashrom. > > Cory Henderson Hello Cory and thanks for your patch! There were a few tiny problems: - white space error (lonely tab in an otherwise empty line), - spi_prettyprint_status_register_sst25 is not completely correct (chip does not have bp2 and bp3), - wrong order within flashchips.c which is understandable because others of the family were wrong too, - maybe I forgot something else, but in general it looked good, thanks again. I just *had* to add two other chips which were missing, and refine a few comments of others... when reviewing the code, before committing it in r1758. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
