On Mon, Jul 14, 2014 at 01:06:18AM +0200, Stefan Tauner wrote:

> > I have an Asus Barebone system, called Asus Vintage 2 PH1. SVN-trunk
> > flashrom version won't flash it initially, but I found a way to do it.
> > 
> > Few words about it:
> > Barebone has its own story, own BIOSes to download, but it looks in
> > strange way: some soft think its Asus P5KPML motherboard, BIOS
> > says its P5LD2-VM, flashrom show P5LD2-MQ. Motherboard tag says
> > "DP_MB/V2-PH1<GA>"
> > 
> > Anyway, it has same problem as P5LD2, but a bit different hardware.
> > 
> > So I added motherboard to a copy of trunk version and flashed it 
> > successfully.
> > 
> > I attach diff file and put log files to download:
> > http://kab00m.ru/temp/flashrom.txz
> > 
> > Hope this will help.
> > 
> 
> Hello Dima,
> 
> thanks for your patch! You wrote that you have successfully flashed
> your board after applying the changes in your patch, but there is no
> log file showing that. 

I used Vintage to flash MSI chip replacing it on the fly. All the
utilities failed to work, I had to boot machine many times, each time
replacing chips. So, when it finally happened - I was too happy to 
record log-file :) Just beleive me :)

> Also, both entries (in print.c and
> board_enable.c) mark the board with "NT" (i.e. not tested). I wonder
> why you did not mark them with "OK"?

I am not a code guru, so I just copy/pasted P5LD2 strings as the most
close one, honestly I was sure it IS P5LD2, but noticed 27b8/27b0
difference later. Sending patch I wasn't sure my only word will
state this enough to approve motherboard for entire project :)

> We would also like to acknowledge your authorship by adding your
> signed-off-by line (and even require that for more complex patches).
> See http://flashrom.org/Developer_Guidelines#Sign-off_Procedure for
> details. In simple cases like this that do not reach the threshold of
> originality I could commit it without it, but I'd appreciate it if you
> would resend the patch possibly with the status fields changed and a
> proper signed-off-by line if you wish.

See attachment. Don't have git, but patch works :)

-- 
Sincerelly yours
Subject: Adding Asus Vintage 2 PH1 (P5LD2-MQ) motherboard

Asus Vintage 2 PH1 barebone system has P5LD2 motherboard series.
Motherboard may be identified as P5LD2-MQ and have V2-PH1 label.
Pin 16 GPIO should be raised to enable write/erase.

Signed-off-by: Dima Veselov <[email protected]>

Index: board_enable.c
===================================================================
--- board_enable.c.orig	2014-07-13 04:54:51.000000000 +0400
+++ board_enable.c	2014-07-14 05:31:32.891460545 +0400
@@ -1663,6 +1663,7 @@ static int intel_ich_gpio_set(int gpio,
  *  - abit IP35: Intel P35 + ICH9R
  *  - abit IP35 Pro: Intel P35 + ICH9R
  *  - ASUS P5LD2
+ *  - ASUS P5LD2-MQ
  *  - ASUS P5LD2-VM
  *  - ASUS P5LD2-VM DH
  */
@@ -2374,6 +2375,7 @@ const struct board_match board_matches[]
 	{0x8086, 0x27b8, 0x103c, 0x2a22,  0x8086, 0x2770, 0x103c, 0x2a22, "^LITHIUM$",  NULL, NULL,           P3, "ASUS",        "P5LP-LE (Lithium-UL8E)",0,   OK, intel_ich_gpio34_raise},
 	{0x8086, 0x27b8, 0x1043, 0x2a22,  0x8086, 0x2770, 0x1043, 0x2a22, "^P5LP-LE$",  NULL, NULL,           P3, "ASUS",        "P5LP-LE (Epson OEM)",   0,   OK, intel_ich_gpio34_raise},
 	{0x8086, 0x27da, 0x1043, 0x8179,  0x8086, 0x27b8, 0x1043, 0x8179, "^P5LD2$",    NULL, NULL,           P3, "ASUS",        "P5LD2",                 0,   NT, intel_ich_gpio16_raise},
+	{0x8086, 0x27da, 0x1043, 0x8179,  0x8086, 0x27b0, 0x1043, 0x8179, "^P5LD2-MQ$", NULL, NULL,           P3, "ASUS",        "P5LD2-MQ",              0,   OK, intel_ich_gpio16_raise},
 	{0x8086, 0x27da, 0x1043, 0x8179,  0x8086, 0x27b8, 0x1043, 0x8179, "^P5LD2-VM$", NULL, NULL,           P3, "ASUS",        "P5LD2-VM",              0,   NT, intel_ich_gpio16_raise},
 	{0x8086, 0x27b0, 0x1043, 0x8179,  0x8086, 0x2770, 0x1043, 0x817a, "^P5LD2-VM DH$", NULL, NULL,        P3, "ASUS",        "P5LD2-VM DH",           0,   OK, intel_ich_gpio16_raise},
 	{0x10DE, 0x0030, 0x1043, 0x818a,  0x8086, 0x100E, 0x1043, 0x80EE, NULL,         NULL, NULL,           P3, "ASUS",        "P5ND2-SLI Deluxe",      0,   OK, nvidia_mcp_gpio10_raise},
Index: print.c
===================================================================
--- print.c.orig	2014-07-13 04:54:42.000000000 +0400
+++ print.c	2014-07-14 05:31:00.268390545 +0400
@@ -749,6 +749,7 @@ const struct board_info boards_known[] =
 	B("ASUS",	"P5L-MX",		OK, "http://www.asus.com/Motherboards/Intel_Socket_775/P5LMX/";, NULL),
 	B("ASUS",	"P5L-VM 1394",		OK, "http://www.asus.com/Motherboards/Intel_Socket_775/P5LVM_1394/";, NULL),
 	B("ASUS",	"P5LD2",		NT, NULL, "Untested board enable."),
+	B("ASUS",	"P5LD2-MQ",		OK, "http://support.asus.com/download.aspx?SLanguage=en&p=8&s=12&m=Vintage-PH2&os=&hashedid=n/a";, NULL),
 	B("ASUS",	"P5LD2-VM",		NT, "http://www.asus.com/Motherboards/Intel_Socket_775/P5LD2VM/";, "Untested board enable."),
 	B("ASUS",	"P5LD2-VM DH",		OK, "http://www.asus.com/Motherboards/Intel_Socket_775/P5LD2VM_DH/";, NULL),
 	B("ASUS",	"P5LP-LE (Lithium-UL8E)", OK, "http://h10025.www1.hp.com/ewfrf/wc/document?docname=c00379616&tmp_task=prodinfoCategory&cc=us&dlc=en&lc=en&product=1159887";, "This is an OEM board from HP."),
_______________________________________________
flashrom mailing list
[email protected]
http://www.flashrom.org/mailman/listinfo/flashrom

Reply via email to