On Fri, 15 Aug 2014 01:09:44 +0200 Carl-Daniel Hailfinger <[email protected]> wrote:
> > -#if CONFIG_INTERNAL == 1 > > - if (programmer_table[programmer].map_flash_region == physmap) > > - snprintf(location, sizeof(location), "at physical address > > 0x%lx", base); > > - else > > -#endif > > - snprintf(location, sizeof(location), "on %s", > > programmer_table[programmer].name); > > - > > That info should not have disappeared, and we may soon have to extend it > for funny constellations like two chips in a programmer (EC flash and > chipset flash for laptops). If this is an important detail we want to tell the user then we need to define a proper interface... there is no reason at all to know the base address in the probing function and that's why I have removed that bit completely, and because I don't see how this is important at all at the msg_pinfo level(!). I would be ok with printing the programmer (well, the master would be better if that's already possible... do they have names already? :) ... but the base address printing needs to die or be moved elsewhere. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
