Hello Antony,

thanks for your patch. It looks good in general, but there are still
some magic constants in the code:
- the initial values for cs_bits and pindir
- 0x11 to enable writes

I guess those can be obtained from the header as well?
-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner

_______________________________________________
flashrom mailing list
[email protected]
http://www.flashrom.org/mailman/listinfo/flashrom

Reply via email to