On Wed, 18 Feb 2015 23:50:49 +0100 Alexandre Boeglin <[email protected]> wrote:
> Le mercredi 18 février 2015 à 01:31, Stefan Tauner a écrit: > > Coverity has brought up the following problems: > > Sorry, I wasn't aware that there were coverity reports for the project. the coverity project is invite-only anyway... and there is not much to see usually because of the rather clean code base :) https://scan.coverity.com/projects/1020?tab=overview > > This patch revamps the function in various ways to fix these issues and some > > other irritating bits. > > It reduces scopes of variables where possible, pushes the code towards our > > coding standards and introduces a label-based resource cleanup at the end. > > I agree, this patch does make the code easier to read, in addition to > fixing my mistakes :) Thanks, I'll take that as an acked-by... because the code is disabled by default anyway ;) Committed in r1885. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
