Hi all, the GitHub PR topic popped up from time to time on IRC in the past but it seems we never discussed it here or came to any conclusion that led to action.
When we switched to Git, we wrote down three ways to send patches [1]: o Via our mailing list o Via gerrit on coreboot.org o Via pull request on flashrom's github mirror Now, roughly 2 years later, some PRs have been merged, but some, even smaller ones, were left unanswered. We also never set a clear process how to move things to Gerrit. While I still don't object to reviewing on Github, if somebody wants to do so, it has some downsides: no global overview of pending patches, no build testing before moving things to Gerrit, the overhead of moving things, ofc (IMHO, reviewing on Github is also much harder, maybe I'm just Gerrit spoiled). Especially the build-test integration makes it hard for me to come up with a reasonable process. Hence, I suggest that we just stop accepting PRs on GitHub and tell contributors to push to Gerrit directly. This may be more work for the contributors and might even scare some away; but I don't see any lack of contributions to this project rather a lack of reviewer resources. So we should make reviewing as easy as possible, IMO. Nico [1] https://www.flashrom.org/Development_Guidelines#Sending_a_patch _______________________________________________ flashrom mailing list -- flashrom@flashrom.org To unsubscribe send an email to flashrom-le...@flashrom.org
