[
https://issues.apache.org/jira/browse/FLEX-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216367#comment-13216367
]
Alex Harui commented on FLEX-19:
--------------------------------
I took a quick look at D (unused locals). Most of it looks good, but I don't
understand the few places where for backward compatibility there is what looks
like a useless statement just to make sure a property gets read. Won't someone
else someday follow up with patch H that removes what seems to be useless code
and just take those out anyway?
> Code style improvements in framework
> ------------------------------------
>
> Key: FLEX-19
> URL: https://issues.apache.org/jira/browse/FLEX-19
> Project: Apache Flex
> Issue Type: Improvement
> Reporter: Martin Heidegger
> Assignee: Bertrand Delacretaz
> Priority: Trivial
> Attachments: A-semicolon.patch, B-nullboolean.patch,
> C-unusedimports.patch, D-unusedlocalvariables.patch, E-returntovoid.patch,
> F-dynamicKeyInVariable.patch, G-unusedprivatemethods.patch
>
>
> After skimming the "framework" sub-project I created a set of patches to the
> source code of various categories.
> A) Missing semicolons in the code
> B) Changed implict casting from object to boolean to a explicit != null
> C) Removed unused imports
> D) Removed local variables that are unused and arguments of private
> functions that are unused
> E) Removed return statement in functions with : void signature
> F) Changed variables named "dynamic" to a name that is not same as a keyword
> G) Removed unused private methods
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
