[
https://issues.apache.org/jira/browse/FLEX-33156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479251#comment-13479251
]
Carol Frampton edited comment on FLEX-33156 at 10/18/12 7:04 PM:
-----------------------------------------------------------------
I believe your change was this so you have an extra check in there. Also I was
suggesting you use fm for both the "if (fm)" and latter for "fm.getFocus()".
var fm:IFocusManager = focusManager;
if (fm)
{
if (isOurFocus(DisplayObject(event.target)))
{
// When we gain focus, make sure the focused element is visible
if (viewport && ensureElementIsVisibleForSoftKeyboard)
{
var elt:IVisualElement = focusManager.getFocus() as
IVisualElement;
lastFocusedElement = elt;
}
}
}
was (Author: cframpton):
I believe your change was so you have an extra check in there. Also I was
suggesting you use fm for both the "if (fm)" and latter for "fm.getFocus()".
var fm:IFocusManager = focusManager;
if (fm)
{
if (isOurFocus(DisplayObject(event.target)))
{
// When we gain focus, make sure the focused element is
visible
if (viewport && ensureElementIsVisibleForSoftKeyboard)
{
var elt:IVisualElement =
focusManager.getFocus() as IVisualElement;
lastFocusedElement = elt;
}
}
}
> focusInHandler() in spark Scroller doesn't null check focusManager property
> before using
> ----------------------------------------------------------------------------------------
>
> Key: FLEX-33156
> URL: https://issues.apache.org/jira/browse/FLEX-33156
> Project: Apache Flex
> Issue Type: Bug
> Components: Spark: Scroller
> Affects Versions: Adobe Flex SDK 4.6 (Release)
> Reporter: Roland Zwaga
> Fix For: Adobe Flex SDK Next
>
> Attachments: Scroller.as.patch
>
>
> the focusHandler() method wrongfully assumes that the focusManager is always
> a valid instance. When checking the focusManager property in UIComponent it
> is clear that in certain cases this property can return a null value.
> So in some cases this can lead to an RTE. I have encountered this once in my
> current project but find it very hard to reproduce. Basically a Scroller
> instance that was displayed in a popup window gave this RTE after the popup
> was removed.
> Reproducable or not, I believe the null check should be added seeing the fact
> that the focusManager property explicitly returns null in some cases.
> I have attached a patch file which adds the null check.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
