Yes the old compiler allows both examples... so I'll commit my change for CSSFunctionCallPropertyValue and then this last failing test will also will turn to "Ok" :).
On Fri, Nov 30, 2012 at 5:37 PM, Gordon Smith <[email protected]> wrote: > I.e., > > <fx:Style> > Button { fontFamily: 'Times Roman' } > </fx:Style> > > instead of > > <fx:Style> > Button { fontFamily: "Times Roman" } > </fx:Style> > > ? If the old compiler allowed this, Falcon should probably allow it. > > - Gordon > > -----Original Message----- > From: Gordon Smith [mailto:[email protected]] > Sent: Friday, November 30, 2012 5:18 PM > To: [email protected] > Subject: RE: Falcon test failure > > I'm not an expert on CSS syntax. Are you supposed to be able to use either > double quotes or single quotes for style values? > > - Gordon > > -----Original Message----- > From: Cyrill Zadra [mailto:[email protected]] > Sent: Friday, November 30, 2012 4:12 PM > To: [email protected] > Subject: Re: Falcon test failure > > Hi Gordon > > Oh I forgot to comment the one line.... > > I exended the method getSingleArgumentFromRaw() to remove single quotes. > But before I commit that I first wanted to ask first here on the list if this > method is really supposed to do that. I'm probably too cautious in commiting > ;-) > > So single quotes should they also be removed if they exists at the beginning > and end of a rawArgument? > > Cyrill > > > > Am 30.11.2012 um 13:03 schrieb Gordon Smith <[email protected]>: > >> @Cyril: Thanks for adding some unit tests for CSS nodes. One test, >> CSSFunctionCallPropertyValue_static_getSingleArgumentFromRaw(), is failing >> for me. It's expecting "Test" but getting "'Test'". >> >> Does it pass for you? >> >> - Gordon
