Hi, I took a really, really quick look over your code. So if I get it correctly, DependencyProcessorMojo is supposed to create RSL for all dependencies of a given project? Ignore the lines above if that is not your intention and then tell me what you wanna do. Well, I have to say, that scares me, and scares me a lot. Imagine for some reason you lost your internet connection in a given period of time. Then, instead of getting the RSLs from the right place you would end generating tons of RSLs that may or may not be correct. It does trigger lot's of red lights on my head. I can see how it help's users circumventing maven correct lifecycle, yes, make things easier, agreed, but, also make then less reliable. Why? Well, the library.SWF (from the 3rd party SWC) has a given checksum. Then you optimize that SWF, which will have a new checksum. In order to get this RSL usable, you need to update this checksum inside the original SWC, that will break maven md5, sha1 and signatures. This is really really bad. To deal with the problem correctly, whoever is publishing the SWC must publish the optimized SWF as well. This is specially trickier when some as3 metadata must be preserved, so it is the role of the person that produces the SWC to produce the optimized SWF as well. Sure, I could accept that, but, FM users already proven that if there is a easier lifecycle that will potentially lead to the problems if you don't really know what you are doing, people will go the easy road then write a huge blog, twitter or whatever saying how flexmojos screw their life.... not blaming on you, just saying what already happen with me more then once. Not really inclined on add such thing into FM code. Not that I did any code last 6 months ;)
About the InstallerMojo, what is the value it brings over OtimizerMojo with optimizeRsls set to false? Am I missing something? VELO On Mon, Jan 17, 2011 at 10:40 PM, rlogiacco <[email protected]> wrote: > I've pushed my changes to my fork on github at > http://github.com/rlogiacco/flexmojos/tree/flexmojos-3.x, I like your > review and suggestions before requesting a pull, it is my very first > contribution to flexmojos. > > > > On Jan 17, 5:18 pm, rlogiacco <[email protected]> wrote: > > Hi all, > > I've produced an update for flexmojos-3 to fix the problem regarding > > metadata and the optimize goal, I'll push the changes on my branch on > > github and I'll request a pull and a release, but I'm still > > experiencing problems with parlsey metadata (which is the reason I > > started working on flexmojos)http://tinyurl.com/4nkmvm6 > > > > Before going further, I've red almost everything I was able to find on > > the topic which seem resolved into flexmojos-4 but we want to continue > > to use flexmojos-3 for the moment so flexmojos-4 is not an option. > > > > I understood the problem in the link is due to a missing option > > providen to the optimization process, specifically it is about the - > > keep-as3-metadata which (I'm guessing here) instruct the optimizer to > > avoid to strip out some metadata information (those specified) from my > > script files while performing optimization. > > > > I slightly changed the OptimizerMojo class to provide that list to the > > optimization process, but it seems it just ignores that parameter. The > > only way I was able to use flexmojos-3 to produce RSLs is avoiding the > > optimization process at all (I've developed a different MOJO that gets > > the library.swf from the SWC without performing the optimization and > > digest steps. > > > > My question is: is this a known bug of the API.optimize ( ... ) > > method? Can someone have a look to my changes to check if I made some > > mistake in using the adobe API? (http://pastebin.com/zHEvVM2N) > > > > I've added an additional MOJO which will help in retrieving RSLs from > > the repositories eventually running the optimization process in case > > the SWF file is not yet available, something already available on > > flexmojos-4 which can be useful for our project and I wished to share. > > > > As my firewall prevents me to push to github I'll put this stuff on my > > fork as soon as possible and I'll request a pull and, possibly, a > > release. > > > > Thanks, > > Roberto > > -- > You received this message because you are subscribed to the Google > Groups "Flex Mojos" group. > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected]<flex-mojos%[email protected]> > For more options, visit this group at > http://groups.google.com/group/flex-mojos > > http://flexmojos.sonatype.org/ > -- You received this message because you are subscribed to the Google Groups "Flex Mojos" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/flex-mojos http://flexmojos.sonatype.org/
