> Adding HasPermission check to avoid this issue would mean changing the > way the AuthorizationProvider::TextReaderForTopic behaves. Instead of > using the AssertTopicPermission, which creates the > FlexWikiAuthorizationException if the call to HasPermission fails, > there would just be a call to HasPermission that would return null if > the HasPermission call failed. Similar changes may also be required > for GetParsedTopic, but I think this is unlikely as the first call > should always be to TextReaderForTopic (he hopes). > > Is this analysis correct? I can run tests Sunday while watching the F1 > race on myPVR.
No, it's not correct. I'm suggesting that the implementation of Collect/whatever call HasPermission - no changes to the way the AuthorizationProvider works. There's still a slight chance for an exception due to race conditions (someone denies permission on a topic after we call HasPermission but before we call TextReaderForTopic or whatever), but in the absence of either transactions or support for concurrent programming in WikiTalk (and we're not going there) then I think it's the best we can do. And the race should be extremely rare in any event. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Flexwiki-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/flexwiki-users
