* Andy Ross -- Monday 09 May 2005 16:06:
> This looks good to me.  It only does the "type forcing" for nodes that
> are (re-) read from a XML file, which is almost certainly correct in
> all cases.

One could even change the patch for props_io.cxx like this:



RCS file: /var/cvs/SimGear-0.3/SimGear/simgear/props/props_io.cxx,v
retrieving revision 1.7
diff -u -p -r1.7 props_io.cxx
--- props_io.cxx        23 Dec 2004 13:32:01 -0000      1.7
+++ props_io.cxx        9 May 2005 14:43:05 -0000
@@ -214,7 +214,10 @@ PropsVisitor::startElement (const char *
       }
     }

-    push_state(node, atts.getValue("type"), mode);
+    const char *type = atts.getValue("type");
+    if (type)
+      node->clearValue();
+    push_state(node, type, mode);
   }
 }




... so that only an explicitly set type would get enforced on overloading,
while omitting the type would keep the old one. Even more sensible and
cautious.

m.

_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@flightgear.org
http://mail.flightgear.org/mailman/listinfo/flightgear-devel
2f585eeea02e2c79d7b1d8c4963bae2d

Reply via email to