* Markus Barenhoff -- Sunday 13 August 2006 14:52:
> if done some code cleanup included in the attached patch.

Eew ... not a unified context diff.
I'd be fine with most of this, except this:


RCS file: /var/cvs/FlightGear-0.9/source/src/GUI/dialog.cxx,v
retrieving revision 1.87
diff -r1.87 dialog.cxx
879c879
<         ALT = 0x4,
---
>         ALT = 0x4


What's the problem with the trailing comma? It's there so that one
can easily add more constants or move others around. This patch
serves no purpose, other than to annoy developers.  :-}

Being able to compile all of sg/fgfs without compiler warnings would
be nice and would make real problems stick out. Of course, different
compilers will show different warnings, and some may only be avoidable
with adding ugly code, but ...

m.  :-)

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Flightgear-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/flightgear-devel

Reply via email to