Selon Tatsuhiro Nishioka :

>
> #ifdef __APPLE__
>       // At the time SGShadowVolume is called, OpenGL extensions and
>       // AlphaBits/StencilBits are not properly recognized on Macs.
>       // so I simply re-initialize it when this method is called for the
> first time
>       static bool re_initialized = false;
>       if (!re_initialized) {
>               this->init(sim_rendering);
>               re_initialized = true;
>       }
> #endif
>
> So here are the questions.
> Am I calling ShadowVolume::init() at an "acceptable" timing?
> Are there any better means of doing this?

a better way would be to do it is without the "#ifdef __APPLE__" condition. If
your change works for you, maybe it will work for us. Propose a patch without
the #ifdef thingy and we'll see if it's ok for the other supported platforms.
Cluttering the source with platform specific #ifdef is the best way to break
something one day or another by someone that doesn't compile on the said
platform.

-Fred

--
Frédéric Bouvier
http://frfoto.free.fr                      Photo gallery - album photo
http://www.fotolia.fr/p/2278/partner/2278  Other photo gallery
http://fgsd.sourceforge.net/               FlightGear Scenery Designer

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel

Reply via email to