* Dave Perry -- Saturday 03 March 2007: > Have you asked to have atmo.diff applied to cvs?.
I don't think it can be applied as it is. I'm no physicist and can't comment on the logic, but there are some formal aspects to fix IMHO: atmo.?xx: - code on the top level must not be indented - proper indentation everywhere (Frankly, 2 spaces aren't enough for my taste. They produce visual spaghetti code.) - comments in a block shall be indented aligned with the block, not begin in column 0 - if (a_tvs_p) delete a_tvs_p; shall be just delete a_tvs_p; - cout/cerr must not be used (use SG_LOG with proper log level) - for (int ii = 0; ; ii++) shall be for (int i = 0; ; i++) - don't add empty *and* commented out class definitions altimeter.cxx: - don't introduce tab indentation in a file that uses 4 spaces - if qqq stands for "quantum, then call it quantum: Altimeter::Altimeter ( SGPropertyNode *node, const double qqq) > > http://www.av8n.com/fly/fgfs/atmo.nas I don't like that at all. What's the use-case of this in other context than instrumentation? It there is none, then it clearly belongs into the instrumentation cxx code. If the calculation is too expensive to do it in every iteration, then use a property with tied getter function, which calculates it whenever it's used and which does the caching. m. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Flightgear-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/flightgear-devel
