Hi Csaba,

On Tuesday 10 July 2007 02:52, Csaba Halász wrote:
> Hi!
>
> I'd like to point out that FGAIBase already has a member for storing
> the callsign. In my ATC patchset I have included a diff that changes
> the affected AI classes to use this common member. I have split my
> modifications into smaller changes so that they can be reviewed and
> applied individually, but nobody cared (it's not too late to check the
> other parts).
>
> Anyway, attached is a new version of the AI patch (for OSG branch)
> which also takes care of a little naming inconsistency involving Path
> vs. SMPath and some const issues.

I'll have a look. Might not be until the weekend though.

FWIW, I completely missed the fact that AIBase had it's own _getCallsign 
function. I've been playing with the tie function a bit yesterday, after 
Melchior reported this to me. Couldn't get it to compile properly when using 
the AIBase::_getCallsign function though. 

>
> Notes: I don't know why
> * the *public* getter methods in AIBase begin with an underscore.

I noticed that too. Seems like an oversight to me. 

> * the callsign is a tied property -- it surely doesn't change too often?

Agreed. It just seemed to me that whenever a propert does change dynamically, 
using a tied property is the more elegant solution, that's all.

Cheers,
Durk

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel

Reply via email to